addpkg(x11/mame): 0.289

[xronin01]

No description provided.

[TomJo2000]

This is overall looking good so far.
I do have a couple suggestions though.

[xronin01]

@TomJo2000 What do you think about packaging only the mame-tools?

[TomJo2000]

@TomJo2000 What do you think about packaging only the mame-tools?

I'd prefer to have both available.

I was just looking at the Arch package build,
judging from some of my earlier review comments you already used this as inspiration for the build.
https://gitlab.archlinux.org/archlinux/packaging/packages/mame/-/blob/0.289-1/PKGBUILD
I'm seeing some clear similarities to the initially submitted build here.
So I don't know how much more can be gleaned from that.

Although I did notice that each of the mame-tools packages comes with a corresponding man page, which isn't currently being installed.
Nvm I missed that.

We can probably also adopt the Lua 5.5 support patch from Arch.

[xronin01]

@TomJo2000 mame requires lua to be compiled with C++.
https://github.com/mamedev/mame/blob/f34f02505e32c1993c6a782b6814232cbfc74e36/scripts/src/3rdparty.lua#L931

Arch has liblua++.
https://gitlab.archlinux.org/archlinux/packaging/packages/lua/-/blob/main/PKGBUILD

[TomJo2000]

That can be arranged.

• I have a pending PR to update Lua to 5.5.1(bump(main/lua55): 5.5.1 #30857),
  so I'll add liblua++ to that.

I think it should be sufficient to only add it for Lua 5.5

[TomJo2000]

@TomJo2000 mame requires lua to be compiled with C++.

I've added liblua55++.so to the PR mentioned above.
It was more of an ordeal than I anticipated.