Teach skill about omit_pr and omit_author options - #33
Merged
Conversation
The add-changelog-entry reference instructed agents to manually write PR numbers into entry frontmatter after filing a PR, bypassing the omit_pr guard on the add command. Respect omit_pr and omit_author when set, and run validate after creating or editing an entry. Co-Authored-By: Claude Fable 5 <[email protected]>
Co-Authored-By: Claude Fable 5 <[email protected]>
Co-Authored-By: Claude Fable 5 <[email protected]>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d23c39ac2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Package-mode changelogs without a config.yaml load omit_pr and omit_author from the adjacent package.yaml, so checking only config.yaml would miss the setting. Co-Authored-By: Claude Fable 5 <[email protected]>
mavam
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 Problem
add-changelog-entryskill reference told agents to manually write PR numbers into entry frontmatter after filing a PR — bypassing theomit_prguard that only exists on theaddcommand.prsmetadata ended up in platform-internal entries despite its config settingomit_pr: true, producing 404 PR links on the public changelog.validateafter entry creation, so nothing caught the violation.🛠️ Solution
omit_pr: true/omit_author: true, record nothing — no flags, no manual frontmatter edits. The guidance covers bothconfig.yamland thepackage.yamlfallback.uvx tenzir-ship validateafter creating or editing an entry.💬 Review
- Guidance-only change; the enforcement lives in the companion validation PR.
- Merge after Validate entries against omit_pr and omit_author #32, which adds the validation check this guidance refers to.
📎 Related: #32