This repository was archived by the owner on Jul 2, 2026. It is now read-only.
Document validation of omit_pr and omit_author - #426
Open
zedoraps wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Fable 5 <[email protected]>
Contributor
|
📦 Preview · View → · 🟢 Live Verified for |
mavam
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 Problem
tenzir-ship validatenow rejects entries carryingprs/authorsmetadata when the config setsomit_pr: true/omit_author: true(tenzir/ship#32), but the ship-framework reference doesn't mention this enforcement.🛠️ Solution
validatecommand section with the new check.omit_pr/omit_authordiscussion that validation catches entries written to disk without theaddcommand.💬 Review
Wording only; no structural changes.
⚙️ Code PR: tenzir/ship#32