Document reference year parsing - #412
Conversation
|
📦 Preview · View → · 🟢 Live Verified for |
3d4186e to
e8bae33
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8bae33b07
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
6c534dc to
c69e010
Compare
Explain how parse_time resolves year-less formats and show the explicit follow-up needed for RFC 3164 syslog timestamps, including timezone offsets supplied with %z. Assisted-by: GPT-5 (Codex)
c69e010 to
2404c1a
Compare
Document that reference fills missing years and fully missing dates, but does not fill only month or day or resolve week-based dates without a year. Assisted-by: GPT-5 (Codex)
Describe only the supported reference completion cases and state that other incomplete date formats return null with a warning. Assisted-by: GPT-5 Codex (Codex)
Time-only formats now choose the date closest to the reference instead of copying it verbatim, and ISO week fields next to a complete calendar date no longer make the format unsupported. Update the reference section and add a midnight example. Co-Authored-By: Claude Fable 5 <[email protected]> Assisted-by: Claude Fable 5 (Claude Code)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28e1372bc6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The fixed-reference example only showed the parse_time assignment but was followed by an output block. Include the from and parse_syslog setup so readers can reproduce the shown result; verified against the tenzir/tenzir#6380 build. Co-Authored-By: Claude Fable 5 <[email protected]> Assisted-by: Claude Fable 5 (Claude Code)
2 participants
🔍 Problem
🛠️ Solution
referenceargument forparse_time.parse_syslogandread_syslog.💬 Review
- Check that the examples make the year and timezone assumptions explicit.
⚙️ Code PR: tenzir/tenzir#6380