Skip to content

fix: stabilize interleaved FFT CPU execution#8

Merged
shinaoka merged 1 commit into
mainfrom
codex/fix-cpu-fft-boundary-test
Jul 18, 2026
Merged

fix: stabilize interleaved FFT CPU execution#8
shinaoka merged 1 commit into
mainfrom
codex/fix-cpu-fft-boundary-test

Conversation

@shinaoka

Copy link
Copy Markdown
Member

Summary

  • add final cube synchronization after interleaved CFFT/RFFT/IRFFT shared-memory stores
  • cap the normal CPU shared-memory path test while preserving the real device-limit test under heavy
  • use checked arithmetic when constructing unsupported FFT lengths so CPU backends with system-RAM limits skip impossible cases

Root cause

CubeCL CPU can reuse shared memory when workers advance to the next cube. Without a final barrier, multi-window interleaved transforms were nondeterministically corrupted. The CPU backend also reports system RAM as shared-memory capacity, making the ordinary boundary test attempt an impractically large FFT.

Verification

  • RUSTUP_TOOLCHAIN=1.97.1 cargo xtask test --ci
  • cargo +1.97.1 test -p cubek-fft --features cubecl/wgpu
  • cargo +1.97.1 test -p cubek-fft --features cubecl/wgpu,heavy
  • cargo +1.97.1 fmt --all -- --check
  • cargo +1.97.1 clippy --no-deps -- --deny warnings

Refs #6

@shinaoka
shinaoka merged commit e66fe2e into main Jul 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant