[codex] Align t4a CubeCL staging rev#4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
t4a-cubecl*staging dependencies to the latest tensor4all CubeCL fork main commitWhy
Tenferro's pre-publish manifest needs to use the same CubeCL source as CubeK. If CubeK points at an older CubeCL git rev while tenferro points at the latest fork rev, Cargo can resolve two separate
t4a-cubeclinstances and split CubeCL runtime types.Validation
cargo fmt --all --checkcargo check -p t4a-cubek-matmul --no-default-featurescargo xtask check lintcargo xtask test --cicargo metadata --format-version 1 --no-depsconfirmedt4a-cubeclandt4a-cubecl-commonresolve from rev6424d9da407d4bc10034aee3bae52705eb5d2da0