[codex] Limit CubeK workspace to t4a publish closure#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
t4a-cubek*crates needed for the temporary tensor4all publish closure plusxtask.cubek-reduce,cubek-fft, and benchmarks from workspace-wide CI commands.Root cause
After #1 merged, CI still ran
cargo clippy --workspaceandcargo doc --workspaceover every crate undercrates/*. Non-published crates such ascubek-reduceare outside the tenferro-required publish closure and do not compile against the pinnedt4a-cubeclfork with Complex element support.Notes
This PR still targets
codex/complex-gemm-api, so it does not mix the C32 matmul API implementation diff intomain.Verification
cargo fmt --all --checkcargo xtask check formatcargo xtask check lintcargo xtask doc buildcargo xtask doc testscargo check -p t4a-cubek-matmul --no-default-featurescargo metadata --no-deps --format-version 1confirmed onlyt4a-cubek-{matmul,std,test-utils,quant,random}remain publishable