Skip to content

[codex] Fix t4a CubeCL xtask selectors #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shinaoka merged 1 commit into from
Jun 22, 2026
Merged

[codex] Fix t4a CubeCL xtask selectors #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions xtask/src/commands/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,15 @@ pub(crate) fn handle_command(
) -> anyhow::Result<()> {
if args.ci {
// Exclude crates that are not supported on CI
args.exclude
.extend(vec!["cubecl-cuda".to_string(), "cubecl-hip".to_string()]);
args.exclude.extend(vec![
"t4a-cubecl-cuda".to_string(),
"cubecl-hip".to_string(),
]);
}
base_commands::build::handle_command(args.try_into().unwrap(), env, context)?;
// Specific additional commands to test specific features
// burn-wgpu with SPIR-V
helpers::custom_crates_build(
vec!["cubecl-wgpu"],
vec!["--features", "spirv"],
None,
None,
"std with SPIR-V compiler",
)?;
helpers::custom_crates_build(
vec!["cubecl-runtime"],
vec!["t4a-cubecl-runtime"],
vec!["--no-default-features"],
None,
None,
Expand Down
20 changes: 6 additions & 14 deletions xtask/src/commands/check.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,32 +14,24 @@ pub(crate) fn handle_command(
) -> anyhow::Result<()> {
if args.ci {
// Exclude crates that are not supported on CI
args.exclude
.extend(vec!["cubecl-cuda".to_string(), "cubecl-hip".to_string()]);
args.exclude.extend(vec![
"t4a-cubecl-cuda".to_string(),
"cubecl-hip".to_string(),
]);
}
base_commands::check::handle_command(args.try_into().unwrap(), env, context)?;
// Specific additional commands to test specific features
// cubecl-wgpu with SPIR-V
// cubecl-wgpu with exclusive-memory-only
// cubecl-runtime without default features
// Disabled on MacOS see:
#[cfg(not(target_os = "macos"))]
helpers::custom_crates_check(
vec!["cubecl-wgpu"],
vec!["--features", "spirv"],
None,
None,
"std with SPIR-V compiler",
)?;
helpers::custom_crates_check(
vec!["cubecl-wgpu"],
vec!["t4a-cubecl-wgpu"],
vec!["--features", "exclusive-memory-only"],
None,
None,
"std with exclusive_memory_only",
)?;
helpers::custom_crates_check(
vec!["cubecl-runtime"],
vec!["t4a-cubecl-runtime"],
vec!["--no-default-features"],
None,
None,
Expand Down
10 changes: 6 additions & 4 deletions xtask/src/commands/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,22 @@ pub(crate) fn handle_command(
if args.miri.is_some() {
// miri tests
args.target = Target::Crates;
args.only.extend(vec!["cubecl-common".to_string()]);
args.only.extend(vec!["t4a-cubecl-common".to_string()]);
base_commands::test::handle_command(args.try_into().unwrap(), env, context)?;
} else {
// conventional tests
if args.ci {
// Exclude crates that are not supported on CI
args.exclude
.extend(vec!["cubecl-cuda".to_string(), "cubecl-hip".to_string()]);
args.exclude.extend(vec![
"t4a-cubecl-cuda".to_string(),
"cubecl-hip".to_string(),
]);
}
base_commands::test::handle_command(args.try_into().unwrap(), env, context)?;
// Specific additional commands to test specific features
// cubecl-wgpu with exclusive-memory-only
helpers::custom_crates_tests(
vec!["cubecl-wgpu"],
vec!["t4a-cubecl-wgpu"],
vec!["--features", "exclusive-memory-only", "--lib"],
None,
None,
Expand Down
Loading