Multibyte first character#18
Open
atrakowski wants to merge 2 commits into
Open
Conversation
9f7c5af to
3201976
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There are names starting with an Umlaut or some other multibyte character, e.g. Öykü Çelik. Currently they are incorrectly lowercased, because the Regexp for upcasing the first letter only matches
/\b\w/i.e./\b[a-zA-Z0-9_]/.Fix
Use a Regexp based on Unicode properties like
/\b\p{Word}/. With that the tests still pass, including a new test for a name starting with a multibyte character.FYI: There are two commits. The first one is the fix itself, in the second commit I've replaced all remaining occurrences of
\wwith\p{Word}. If the latter is too much of a change, I can easily undo it.