[DT-3930] Fix login page theming with DarkMode overrideTheme#3563
Draft
andrewzamojc wants to merge 1 commit into
Draft
[DT-3930] Fix login page theming with DarkMode overrideTheme#3563andrewzamojc wants to merge 1 commit into
andrewzamojc wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
DarkMode now accepts an `overrideTheme` prop ('light' | 'dark') that supersedes the user's dark-mode preference and writes it to body[data-theme]. The (login) layout mounts <DarkMode overrideTheme="light" /> so login-page components stop resolving dark-mode colors against a hardcoded light surface. Also fixes a leaked store subscription in the darkMode action.
DT-3930
andrewzamojc
force-pushed
the
dt-3930-login-page-hardcodes-a-white-background
branch
from
92410fe to
ba11825
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The login page presents a hardcoded light surface, but child components (e.g. a Holocene
Link) still resolved their dark-mode colors viaprefers-color-scheme, producing white-on-white in dark mode.This adds an
overrideTheme?: 'light' | 'dark'prop to theDarkModecomponent /darkModeaction. When set, it supersedes the user's dark-mode store/system preference and writes the value straight tobody[data-theme]; when absent, behaviour is unchanged. The(login)layout now mounts<DarkMode overrideTheme="light" />so login-page components render consistently in light mode. Also fixes a leaked store subscription in thedarkModeaction (now unsubscribes ondestroy).Consumers like cloud-ui can drive this from page data via
overrideTheme={override ?? undefined}.Jira
https://temporalio.atlassian.net/browse/DT-3930
Test plan