Skip to content

a11y(4.1.3): Toaster role="log" → per-toast role="status"/"alert" for correct AT announcement semantics #3560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rosanusi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

a11y(4.1.3): Toaster role="log" → per-toast role="status"/"alert" for correct AT announcement semantics #3560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/lib/holocene/toast.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<script lang="ts">
import type { HTMLAttributes } from 'svelte/elements';
import { fly } from 'svelte/transition';

import { createEventDispatcher } from 'svelte';
Expand Down Expand Up @@ -27,13 +28,18 @@
warning: 'warning',
};

function getRole(v: ToastVariant): HTMLAttributes<HTMLDivElement>['role'] {
if (v === 'error') return 'alert';
return 'status';
}

export let id: string;
export let variant: keyof typeof variants;
export let closeButtonLabel: string = '';

$: dismissLabel = closeButtonLabel || translate('common.close');

$: icon = variantIcon[variant];
$: role = getRole(variant);

const handleDismiss = () => {
dispatch('dismiss', { id });
Expand All @@ -42,6 +48,8 @@

<div
{id}
{role}
aria-atomic="true"
class={merge(
'flex grow-0 items-center justify-between gap-4 rounded-md px-3 py-2.5 shadow',
variants[variant],
Expand Down
2 changes: 1 addition & 1 deletion src/lib/holocene/toaster.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
});
</script>

<div class={toast({ position: $position })} role="log">
<div class={toast({ position: $position })}>
{#each $toasts as { message, variant, id, link } (id)}

@temporal-cicd temporal-cicd Bot Jun 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Type 'ToastVariant | undefined' is not assignable to type 'ToastVariant'.
  • ⚠️ Type 'string | undefined' is not assignable to type 'string'.

<ToastComponent {closeButtonLabel} {variant} {id} on:dismiss={dismissToast}>
{#if link}
Expand Down
Loading