Schedules redesign 5/5: view page, list, and action modals by tegan-temporal · Pull Request #3552 · temporalio/ui

tegan-temporal · 2026-06-11T18:10:25Z

Description & motivation 💭

Final PR of the stack. After this merges, feature/schedules is byte-identical to tegan/schedules-update (verified with an empty git diff).

New schedule-view/ card-based page: spec card with full-spec toggle, advanced settings, recent/upcoming workflow runs, workflow input, custom search attributes
schedule-action-modals/: trigger, backfill, and pause modals rendered through a conditionally-mounted host keyed on the confirmation-modal store, so every open starts with fresh state (no stale selections, reasons, or page-load timestamps). Trigger pre-selects Allow All (matching server behavior for manual triggers) and both overlap pickers mark the schedule's current policy
Backfill modal interprets entered times in the schedule's timezone (caption shows it) and disables confirm when end ≤ start
List components move to schedules-list/
Final cleanup: deletes the superseded view components, schedule-spec-label, legacy schedule types (ScheduleParameters family, Unspecified overlap policy), and legacy i18n keys

Testing 🧪

How was this tested 👻

Manual testing
E2E tests added
Unit tests added

pnpm check 0 errors, pnpm lint 0 errors, 2,080 unit tests passing, full integration suite 233 passed / 0 failed. New schedule-actions.spec.ts covers trigger patch bodies, backfill request + post-success modal usability, modal state reset on reopen, timezone caption, end-before-start validation, and delete. The e2e spec now does a full create → verify summary → delete loop but needs a run against a real Temporal server (not runnable locally).

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

On a schedule view page: trigger, backfill (try an end time before the start time, and reopen modals to confirm state resets), pause/unpause with a reason, and delete.

Checklists

Merge Checklist

Schedules redesign 4/5: form and stores rewrite #3551 merges first
Run e2e suite against a real server before merging feature/schedules to main
Merges into feature/schedules (not main)

🤖 Generated with Claude Code

Replaces the schedule view page with card-based components (spec, advanced settings, workflow runs, input, search attributes), adds the trigger/backfill/pause modals behind a conditionally-mounted host so modal state resets on every open, and moves the list components under schedules-list/. The backfill modal interprets times in the schedule's timezone and validates that the end time follows the start time. Removes the superseded view components, legacy schedule types and i18n keys, and schedule-spec-label. Adds action-modal integration coverage and extends the e2e spec to a full create/verify/delete loop. Co-Authored-By: Claude Fable 5 <[email protected]>

vercel · 2026-06-11T18:10:32Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
holocene	Ready	Preview, Comment	Jun 15, 2026 9:23pm

The payload input now validates JSON for json/plain encoding, so submit a JSON string, and the schedule heading contains the status badge, so match on containment. Co-Authored-By: Claude Fable 5 <[email protected]>

laurakwhit

Looking good! Noticed a few small things, but no major blockers.

laurakwhit · 2026-06-16T22:56:00Z

+    return runs
+      .filter(Boolean)
+      .sort(
+        (a, b) => getMilliseconds(a.actualTime) - getMilliseconds(b.actualTime),


Do we want the newest (not the oldest) to show here?

Suggested change

(a, b) => getMilliseconds(a.actualTime) - getMilliseconds(b.actualTime),

(a, b) => getMilliseconds(b.actualTime) - getMilliseconds(a.actualTime),

laurakwhit · 2026-06-16T22:56:59Z

+      </dd>
+    </div>
+
+    {#if state.limitedActions}


Suggested change

{#if state.limitedActions}

{#if state?.limitedActions}

laurakwhit · 2026-06-16T22:59:07Z

+        data-testid="schedule-name"
+      >
+        <WorkflowStatus
+          status={schedule?.schedule.state.paused ? 'Paused' : 'Running'}


Suggested change

status={schedule?.schedule.state.paused ? 'Paused' : 'Running'}

status={schedule?.schedule?.state?.paused ? 'Paused' : 'Running'}

laurakwhit · 2026-06-16T22:59:25Z

+          </dd>
+        </div>
+
+        {#if schedule?.info.updateTime}


Suggested change

{#if schedule?.info.updateTime}

{#if schedule?.info?.updateTime}

laurakwhit · 2026-06-16T23:00:43Z


-  let { input, scheduleId }: { input: Payloads; scheduleId: string } = $props();
+  interface Props {
+    input: Payloads;


NIT: Can the input be null here?

laurakwhit · 2026-06-16T23:21:02Z

+      {translate('schedules.schedule-specs')}
+    </h2>
+    <Button
+      variant="ghost"


NIT: Wondering if this should be a "secondary" button or maybe just have an up/down chevron icon? Or Maybe a toggle would be more intuitive here?

laurakwhit · 2026-06-16T23:22:48Z

+    </h1>
+  </div>
+</header>
+<Loading />


NIT: Instead of a loading spinner, wondering if we should follow the pattern of a skeleton loader we have elsewhere when loading a full page.

laurakwhit · 2026-06-16T23:24:39Z

+          <dd class="inline-flex items-center gap-1">
+            {schedule?.schedule?.action?.startWorkflow?.workflowType?.name}
+            <div class="flex items-center gap-2">
+              <Link


Could we use the DetailList components here? E.g. DetailListLinkValue.

laurakwhit · 2026-06-16T23:26:56Z

+  </header>
+
+  <PillContainer class="mr-auto flex flex-row p-1">
+    <Pill


Curious why pills instead of our ToggleButtons or Tabs?

laurakwhit · 2026-06-16T23:30:35Z

+      <span class="font-mono" data-testid="workflow-count"
+        >{$workflowCount.count.toLocaleString()}
+      </span>
+      <Button


Can we use the existing CountRefreshButton here?

tegan-temporal requested a review from a team as a code owner June 11, 2026 18:10

vercel Bot deployed to Preview June 11, 2026 18:11 View deployment

Fix schedules e2e test for redesigned form

889107d

The payload input now validates JSON for json/plain encoding, so submit a JSON string, and the schedule heading contains the status badge, so match on containment. Co-Authored-By: Claude Fable 5 <[email protected]>

tegan-temporal force-pushed the tegan/schedules-pr5-view branch from 7e0c7aa to 889107d Compare June 11, 2026 18:27

vercel Bot deployed to Preview June 11, 2026 18:28 View deployment

tegan-temporal requested review from Alex-Tideman, laurakwhit and rossnelson June 11, 2026 18:43

tegan-temporal self-assigned this Jun 11, 2026

Merge form updates

f51594d

vercel Bot deployed to Preview June 11, 2026 19:17 View deployment

Merge form updates

6fe411d

vercel Bot deployed to Preview June 11, 2026 19:43 View deployment

Merge form updates

d25d05d

vercel Bot deployed to Preview June 11, 2026 21:28 View deployment

Merge branch 'tegan/schedules-pr4-form' into tegan/schedules-pr5-view

8d0eaac

vercel Bot deployed to Preview June 15, 2026 21:23 View deployment

laurakwhit reviewed Jun 16, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Schedules redesign 5/5: view page, list, and action modals#3552

Schedules redesign 5/5: view page, list, and action modals#3552
tegan-temporal wants to merge 6 commits into
tegan/schedules-pr4-formfrom
tegan/schedules-pr5-view

tegan-temporal commented Jun 11, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Jun 11, 2026 •

edited

Loading

Uh oh!

laurakwhit left a comment

Uh oh!

laurakwhit Jun 16, 2026

Uh oh!

laurakwhit Jun 16, 2026

Uh oh!

laurakwhit Jun 16, 2026

Uh oh!

laurakwhit Jun 16, 2026

Uh oh!

laurakwhit Jun 16, 2026

Uh oh!

laurakwhit Jun 16, 2026

Uh oh!

laurakwhit Jun 16, 2026

Uh oh!

laurakwhit Jun 16, 2026

Uh oh!

laurakwhit Jun 16, 2026

Uh oh!

laurakwhit Jun 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	(a, b) => getMilliseconds(a.actualTime) - getMilliseconds(b.actualTime),
	(a, b) => getMilliseconds(b.actualTime) - getMilliseconds(a.actualTime),

	status={schedule?.schedule.state.paused ? 'Paused' : 'Running'}
	status={schedule?.schedule?.state?.paused ? 'Paused' : 'Running'}

	{#if schedule?.info.updateTime}
	{#if schedule?.info?.updateTime}

Conversation

tegan-temporal commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description & motivation 💭

Testing 🧪

How was this tested 👻

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Merge Checklist

Uh oh!

vercel Bot commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laurakwhit left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tegan-temporal commented Jun 11, 2026 •

edited

Loading

vercel Bot commented Jun 11, 2026 •

edited

Loading