Skip to content

a11y(2.5.8): chip — pad remove button to 24×24 CSS px minimum #3544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rosanusi wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −1
Open

a11y(2.5.8): chip — pad remove button to 24×24 CSS px minimum #3544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56d30d4
a11y(2.5.8): chip — pad remove button to 24×24 CSS px minimum
rosanusi Jun 11, 2026
5b9ca19
a11y(manifest): add 2.5.8-chip-remove-button — bucket 1, ui-main, mod…
ardiewen Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions scripts/a11y/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,13 @@
bucket: 3
severity: serious
scope: ui-main
- slug: 2.5.8-chip-remove-button
sc: '2.5.8'
bucket: 1
severity: moderate
scope: ui-main
files-touched:
- src/lib/holocene/chip.svelte
- slug: 2.5.8-pagination-caret-buttons
sc: '2.5.8'
bucket: 2
Expand Down
5 changes: 4 additions & 1 deletion src/lib/holocene/chip.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,10 @@
{/if}
<button
aria-label={removeButtonLabel}
class={disabled ? 'hidden' : ''}
class={merge(
'inline-flex items-center justify-center p-1',
disabled ? 'hidden' : '',
)}
data-track-name="chip"
data-track-intent="remove"
data-track-text={removeButtonLabel}
Expand Down
Loading