Skip to content

[WCAG 2.4.11] Add scroll-padding to prevent sticky overlays from obscuring focused elements #3532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rosanusi wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WCAG 2.4.11] Add scroll-padding to prevent sticky overlays from obscuring focused elements #3532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed27e12
[WCAG 2.4.11] Add scroll-padding to prevent focus obscured by sticky …
rosanusi Jun 10, 2026
a67445c
fix: resolve stylelint length-zero-no-unit and custom-property-empty-…
rosanusi Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,19 @@
@layer base {
:root {
--top-nav-height: 3rem;
--banner-height: 0px;
--bottom-nav-height: 4rem;
--panel-collapsed-w: 60px;
--panel-expanded-w: 240px;
--panel-h: 73dvh;
}

@media (min-width: 768px) {
:root {
--bottom-nav-height: 0px;
}
}

*,
html,
body {
Expand Down
16 changes: 15 additions & 1 deletion src/lib/holocene/banner/banner.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
</script>

<script lang="ts">
import { BROWSER } from 'esm-env';
import { twMerge as merge } from 'tailwind-merge';

import Button from '$lib/holocene/button.svelte';
Expand Down Expand Up @@ -69,13 +70,26 @@

$: show = message && !$dismissedBanners[id];

let bannerHeight = 0;

$: if (BROWSER) {
document.documentElement.style.setProperty(
'--banner-height',
show ? `${bannerHeight}px` : '0px',
);
}

const dismissBanner = () => {
$dismissedBanners[id] = true;
};
</script>

{#if show}
<section class={merge(types({ type }), className)} {...$$restProps}>
<section
class={merge(types({ type }), className)}
bind:clientHeight={bannerHeight}
{...$$restProps}
>
<span class="flex items-center gap-2">
{#if icon}
<Icon name={icon} />
Expand Down
6 changes: 5 additions & 1 deletion src/lib/holocene/main-content-container.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@
let { children, main, footer }: Props = $props();
</script>

<div id="content-wrapper" class="relative h-full w-max flex-auto overflow-auto">
<div
id="content-wrapper"
class="relative h-full w-max flex-auto overflow-auto"
style="scroll-padding-top: calc(var(--top-nav-height, 3rem) + var(--banner-height, 0)); scroll-padding-bottom: var(--bottom-nav-height, 0);"
>
{@render children?.()}
<main id="content" tabindex="-1" class="pb-16 md:pb-0">
{@render main?.()}
Expand Down
4 changes: 4 additions & 0 deletions src/lib/holocene/table/paginated-table/index.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
export { className as class };

let tableContainer: HTMLDivElement;
let footerHeight = 0;

$: tableOffset = tableContainer?.offsetTop
? tableContainer.offsetTop + 32
Expand All @@ -45,6 +46,8 @@
id="{$$restProps['id']}-container"
bind:this={tableContainer}
style="max-height: {maxHeight || `calc(100vh - ${tableOffset}px)`};
scroll-padding-top: var(--table-header-h, 2.25rem);
scroll-padding-bottom: {footerHeight}px;

--table-header-h: 2.25rem;"
>
Expand All @@ -63,6 +66,7 @@
{#if visibleItems.length}
<div
class="surface-primary sticky bottom-0 left-0 flex w-full grow items-center justify-between gap-2 border-t border-subtle px-4 py-2"
bind:clientHeight={footerHeight}
>
<slot name="actions-start" />
<slot name="actions-center" />
Expand Down
Loading