feat(DT-4079): miscellaneous WD UI fixes#3511
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| {open} | ||
| confirmText={translate('common.confirm')} | ||
| cancelText={translate('common.cancel')} | ||
| on:confirmModal={() => onConfirm?.(percentage)} |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type '(() => void) | undefined' is not assignable to parameter of type '(e: CustomEvent) => void'.
| {open} | ||
| confirmText="" | ||
| cancelText={translate('common.close')} | ||
| hideConfirm |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type '(() => void) | undefined' is not assignable to parameter of type '(e: CustomEvent) => void'.
Member
I noticed in #3518 PR screenshots that the border is around the icon + label: 
Apologies if this wasn't clear, but it should be like Namespace Regions in the list table. I border should be around the cloud provider icon only. 
|
laurakwhit
reviewed
Jun 11, 2026
laurakwhit
reviewed
Jun 11, 2026
laurakwhit
approved these changes
Jun 12, 2026
- Hide "Set Current Version" menu item for versions already current - Re-arrange deployment detail header: Create New Version as primary, More Actions menu with View Workflows / Ramp to Unversioned / Delete - Add Ramp to Unversioned Workers modal with percentage input - Show alert banner when unversioned workers are ramping with Edit/Delete actions - Remove border box from ComputeBadge — use plain icon + label styling
Calls set-current-version with an empty version string, transitioning the version to Draining then Drained so it can be deleted. Prerequisite for fully emptying a deployment (DT-4077).
…tion to modal Replace custom banner div with Alert component; remove inline Edit/Delete buttons. Move the remove action into the Ramp to Unversioned Workers modal as a destructive footer button, shown only when ramping is active.
Adds a kebab actions menu to the deployments list with a Delete item. Shows a blocked modal when versions exist (all must be removed first), or a destructive confirm modal requiring the user to type DELETE when the deployment has no versions.
- Use camelCase buildId (not build_id) in ramp/remove API calls
- Add conflictToken support to removeRampingUnversionedWorkers
- Add error handling to handleRemoveRampUnversioned
- Fix 0% ramp falsy check (use != null instead of truthiness)
- Remove unused Button import from deployment.svelte
- Replace invisible-class pattern with {#if} in ramp modal
- Add confirm modal + error handling for Unset Current action
- Include deployment name in delete deployment modal description
Matches the Namespace Region style — border wraps the cloud provider icon alone, with the label rendered as plain text beside it.
…elete - unsetCurrentDeploymentVersion: use buildId (not version) and pass conflictToken - version-table-row: pass conflictToken through to unset call - deployment-table-row: fetch full deployment on modal open to get conflictToken
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set-ramping-versionAPI with emptybuild_id[icon] labelmatching the Namespace Region styleset-current-versionwith an empty version string, which transitions the version to Draining and eventually Drained, allowing it to be deleted. Without this, a deployment could never be fully emptied (and therefore never deleted) because one version is always pinned as current.Test plan