Fixed some controls and add auto zone defense#137
Merged
Conversation
scotch-tape
commented
Mar 20, 2026
scotch-tape
commented
Contributor
- made the operator passing button left trigger
- made the operator stop autoshoot button x
- made the driver zero heading button left bumper
- made lock motion use static brake instead of position control
- made the driver abxy buttons do auto zone defense
- once auto trench is added, driver right bumper should run it
codeNinja-1
requested changes
Mar 20, 2026
codeNinja-1
left a comment
codeNinja-1
left a comment
Collaborator
There was a problem hiding this comment.
Great work on this! There's some code that should be cleaned up a bit to make it more maintainable in the future, and a few fixes with the triggers that we might have forgotten to do earlier.
Removed commented out imports, and applied spotless
…both autoshootTrigger and autoPassTrigger. Added .and(operator.a().negate()) and .and(operator.y().negate()) to both autoshootTrigger and autoPassTrigger.
codeNinja-1
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.