validate edge product in Mat_VarGetCells and Mat_VarGetStructs#318
Open
naruto-lgtm wants to merge 1 commit into
Open
validate edge product in Mat_VarGetCells and Mat_VarGetStructs#318naruto-lgtm wants to merge 1 commit into
naruto-lgtm wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro: Mat_VarGetCells on a rank-2 cell array with edge={3, 1431655766}.
Cause: N, the product of edge[], is accumulated in a signed int with no overflow guard. 3*1431655766 wraps to 2, so the pointer array is malloc'd for two cells while the copy loop still writes cells[0..2], one past the allocation (ASan heap-buffer-overflow in matvar_cell.c). Mat_VarGetStructs sizes its field array from the same unchecked product.
Fix: reject a negative edge or a product past INT_MAX before the allocation in both, matching CheckEdgeOverflow in the fixed-rank slab readers. Valid selections are unchanged.