ci: add luatest submodule (requires dropping support for 1.10)#658
Draft
Serpentian wants to merge 1 commit into
Draft
ci: add luatest submodule (requires dropping support for 1.10)#658Serpentian wants to merge 1 commit into
Serpentian wants to merge 1 commit into
Conversation
Since commit ed80182 ("ci: bump test-run"), luatest isn't shipped with test-run anymore. Instead, developers are supposed to install it from rocks. It isn't really convenient because to do it, you have to install the tt and tarantool packages first, i.e. to test tarantool built from sources you have to install the tarantool binary package first, which looks weird. True, one can make tt use a freshly built tarantool's binary and headers, but that's tricky. Let's add luatest as a submodule to the tarantool repository. This makes test-run use it if it doesn't find luatest in rocks, see tarantool/test-run#459, but it also must be bumped for that to work. NO_DOC=build NO_TEST=build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since commit ed80182 ("ci: bump test-run"), luatest isn't shipped with test-run anymore. Instead, developers are supposed to install it from rocks. It isn't really convenient because to do it, you have to install the tt and tarantool packages first, i.e. to test tarantool built from sources you have to install the tarantool binary package first, which looks weird. True, one can make tt use a freshly built tarantool's binary and headers, but that's tricky. Let's add luatest as a submodule to the tarantool repository. This makes test-run use it if it doesn't find luatest in rocks, see tarantool/test-run#459, but it also must be bumped for that to work.
NO_DOC=build
NO_TEST=build