This repository was archived by the owner on Aug 3, 2026. It is now read-only.
fix: validate Shasta grandparent base fee - #697
Merged
Conversation
johntaiko
approved these changes
Jun 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Ports the Shasta grandparent/base-fee validation hotfix to main, tightening first-block base-fee validation by ensuring the L2 grandparent header linkage is verified and by running validation after manifest selection so fallback manifests can’t bypass it. Also updates SGX Gramine manifest templates to carry additional dev fork env bindings for consistent enclave measurement paths across build modes.
Changes:
- Move Shasta base-fee validation to occur after protocol/default manifest selection in Shasta transaction generation.
- Strengthen Shasta base-fee validation by requiring a correctly linked L2 grandparent header (reject missing/mismatched grandparent).
- Add missing dev fork env bindings to SGX Gramine manifest templates.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| provers/sgx/config/sgx-guest.local.manifest.template | Adds DEV_SHASTA_TIMESTAMP env binding for local SGX guest manifest parity. |
| provers/sgx/config/sgx-guest.docker.manifest.template | Adds dev fork env bindings for Docker SGX guest manifest (noted inconsistency to address). |
| lib/src/utils/shasta.rs | Runs Shasta base-fee validation after manifest selection (default fallback can’t skip validation). |
| lib/src/utils/shasta_rules.rs | Requires/validates L2 grandparent linkage when computing first-block Shasta base fee; adds targeted tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gaikoto47944ca(taikoxyz/gaiko#31) to remove committed enclave signing materialTest Plan
gaiko@47944cadoes not containdocker/enclave-key.pemor PEM private-key material