WIP - Remove all mocks from tests - #30
Closed
johnnyshields wants to merge 12 commits into
Closed
Conversation
When IPC fork stages received EndOfStage, they never propagated it to the output queue, causing downstream IPC stages to wait indefinitely. This commit propagates EndOfStage immediately after sending :end_of_stage to workers, preventing the deadlock. However, this creates a race condition where EndOfStage may be signaled before all worker results are collected. Works for: - IPC processor -> IPC consumer (examples 92, reroute cases) - COW fork stages (examples 93, 94) - Mixed executors Known issues: - IPC processor -> IPC processor has race conditions (examples 74-76, 71, 88) - EndOfStage bypasses workers instead of flowing through them - Proper fix requires architectural changes to IPC completion detection 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
● I see the issue. The jepsen tests are failing because they use real stages, and those stages don't have
a task. Let me check that test file:
● Search(pattern: "let\(:stage\)|let\(:mock_pipeline\)|ConsumerStage\.new", path:
"spec/unit/execution/fork_executors_jepsen_spec.rb", output_mode: "content")
⎿ Found 5 lines (ctrl+o to expand)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also need to remove instance_variable_get/set