Skip to content

fix(tests): parse changelog version with Select-String instead of break in ForEach-Object #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tablackburn wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(tests): parse changelog version with Select-String instead of break in ForEach-Object #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ed0a7f
fix(tests): parse changelog version with Select-String instead of bre…
tablackburn May 27, 2026
4497839
fix(tests): guard changelog version parse against no match
tablackburn May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions tests/Manifest.tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,15 @@ BeforeAll {
# Parse the version from the changelog
$changelogPath = Join-Path -Path $Env:BHProjectPath -ChildPath 'CHANGELOG.md'
$changelogVersionPattern = '^##\s\\?\[(?<Version>(\d+\.){1,3}\d+)\\?\]' # Matches on a line that starts with '## [Version]' or '## \[Version\]'
$changelogVersion = Get-Content $changelogPath | ForEach-Object {
if ($_ -match $changelogVersionPattern) {
$changelogVersion = $matches.Version
break
}
# Select-String returns the first matching line's named capture directly — no loop and no
# 'break' (which is unreliable inside ForEach-Object, since a pipeline is not a loop).
# Capture the MatchInfo first and guard for no match, so a missing or malformed changelog
# heading leaves $changelogVersion as $null (failing the assertion below cleanly) instead of
# throwing "Cannot index into a null array" here in BeforeAll.
$changelogMatch = Select-String -Path $changelogPath -Pattern $changelogVersionPattern |
Select-Object -First 1
$changelogVersion = if ($changelogMatch) {
$changelogMatch.Matches[0].Groups['Version'].Value
}
}
Describe 'Module manifest' {
Expand Down
Loading