build: pin toolchain and neutralize stale host GOROOT#23
Open
syscod3 wants to merge 1 commit into
Open
Conversation
A GOROOT exported by the host shell (pointing at a different Go than the mise-managed toolchain) caused 'compile: version mismatch' on every build. Makefile now unexports GOROOT for all recipes, and .mise.toml unsets it under mise activation, so builds use the pinned toolchain independent of the host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 'compile: version go1.X.0 does not match go tool version go1.Y.Z' build failures caused by a stale
GOROOTexported by the host shell (pointing at a different Go than the mise-managed toolchain on PATH).Changes
unexport GOROOT— every recipe uses the go binary's own GOROOT, independent of the host's Go install.[env] GOROOT = false— under mise activation, the pinnedgo = "1.25.8"toolchain is used regardless of any host GOROOT.Verification
make buildandGOOS=linux mise exec -- go build ./...both pass with a staleGOROOT=/usr/local/Cellar/go/1.26.0/libexecstill exported.Independent of any feature work; landing on main so all agents/devs get a reproducible build.