[mlir][tosa] Limit shape op level checks to MAX_SHAPE_LEN - #15
Open
atabakp wants to merge 1 commit into
Open
Conversation
Cherry-pick of llvm/llvm-project@bc010989719d, adapted to the shape ops present in this tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of llvm/llvm-project@bc010989719d. Replaces #13.
#13 works around the failure by globally disabling shape-type rank validation. This is the upstream root-cause fix: shape ops are level-checked against a new MAX_SHAPE_LEN (16 at level 8K, 64 at NONE), and the incorrect blanket MAX_RANK check on all shapeTypes is removed. A pad shape operand is 2*rank, so it was never correct to check it against MAX_RANK.
Confirmed on the #13 case (in16x1x48, k3x1, oc48, s2x1): the stride-2 decomposition emits
tosa.padwith!tosa.shape<8>, which failsexceeds MAX_RANKon torq-3.10 and passes with this change.Adapted: only AddShape, DivCeilShape, DivFloorShape, MulShape and SubShape exist in this tree, so the remaining conversions and their tests are omitted.