Skip to content

[wallet/symbol/mobile] fix: Multisig Account Modification confirmation dialog text - #2452

Open
OlegMakarenko wants to merge 1 commit into
devfrom
wallet/multisig-modal-text
Open

[wallet/symbol/mobile] fix: Multisig Account Modification confirmation dialog text#2452
OlegMakarenko wants to merge 1 commit into
devfrom
wallet/multisig-modal-text

Conversation

@OlegMakarenko

@OlegMakarenko OlegMakarenko commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Problem:

  • The multisig confirmation dialog always shows the title "Confirm Multisig Creation", even when the user is modifying an existing multisig account — this doesn't match the "Modify Multisig Account" screen and is misleading.
  • The dialog body also reuses the create-specific text ("You are about to create a multisig account at %{address}...") during the modify flow, which is inaccurate since no new account is being created.
  • Root cause: both the create and modify flows reuse the same localization key (s_multisig_create_dialog_confirm_title), which is only correct for the create flow.

Solution:

  • Added a separate modify-flow string for the confirmation dialog title and body, distinct from the create-flow strings.
  • Updated the confirmation dialog to select the create vs. modify copy based on which flow triggered it.

Resolved: #2397

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.37%. Comparing base (f26cf7f) to head (3523bf6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2452      +/-   ##
==========================================
- Coverage   95.59%   95.37%   -0.23%     
==========================================
  Files         716      679      -37     
  Lines       53377    50606    -2771     
  Branches     1403     1404       +1     
==========================================
- Hits        51027    48265    -2762     
+ Misses       2291     2284       -7     
+ Partials       59       57       -2     
Flag Coverage Δ
explorer-puller ?
explorer-rest ?
wallet-mobile-symbol 94.17% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ile/src/screens/multisig/ModifyMultisigAccount.jsx 97.84% <100.00%> (ø)

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OlegMakarenko
OlegMakarenko marked this pull request as ready for review July 27, 2026 16:15

@Wayonb Wayonb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[wallet/symbol/mobile] Incorrect confirmation dialog title when modifying a multisig account

2 participants