Removing the encoding seems to have resolved issues on py 2.7#44
Open
megalithic wants to merge 1 commit into
Open
Removing the encoding seems to have resolved issues on py 2.7#44megalithic wants to merge 1 commit into
megalithic wants to merge 1 commit into
Conversation
|
I'm facing similar behaviour - it's somewhat weird that using python 2.7 I would need to decode the message containing unicode characters, but the title and subtitle doesn't need any decoding. This change would fix the problem at least for me too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was wrong with my last one, it doesn't seem to need any encoding, this is on python 2.7. I'm not sure if my situation is different from the "norm", but for me, removing the re-assignment of
messageto encode it does in fact completely fix the issues I was having. My last fix I was still getting intermittent failures.Sorry about that.