Conversation
…icon - core: untitled modules display their file name (no path) instead of a blank header — flows to both frontends, window title, and Now Playing - GUI header subtitle shows the current file name after format · artist - GUI meter bars are three-zone gradients (meter_low/mid/high) like the TUI, with the track recessed toward the background; fixes themes whose meter_low sits close to the track color (e.g. seoul's Namsan Green vs Palace Brown). Peak-hold tick is now fg for universal contrast - opening the queue scrolls the playing track to ~1/3 from the top (scroll clamping degrades it to "just visible" near list ends) - queue's shuffle toggle is a crossing-arrows icon, matching the other icon controls
Only the outer ends of a bar are rounded; interior zone boundaries butt together so the fill reads as one continuous bar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five fixes from real-world use:
rtrax-core::audio::load_module, so the TUI, GUI, window title, and OS Now Playing all inherit the fallback. Unit-tested.format · artist · song.xm.meter_low/meter_mid/meter_highacross the width, exactly like the TUI meters) instead of a singlemeter_lowfill, and the track is recessed toward the background. Fixes muted custom themes — e.g. seoul's dark-greenmeter_low(#455f54) against brown track (#594743) was nearly invisible; now the mid/high zones (ginkgo yellow, dancheong red) carry the contrast. Peak-hold tick changed tofgso it reads in every palette.Tested: fmt/clippy/tests green (new core test for the title fallback); smoke-launched with the seoul custom theme and a multi-file queue.