Skip to content

Close response body in SendEvent/HealthCheck to fix FD + memory leak (#15) #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaeltoop wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Close response body in SendEvent/HealthCheck to fix FD + memory leak (#15) #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions swarmpit/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
package swarmpit

import (
"io"
"log"
"time"
"bytes"
"io/ioutil"
"net/http"
"encoding/json"
"github.com/swarmpit/agent/setup"
Expand Down Expand Up @@ -40,18 +42,27 @@ func SendEvent(eventType EventType, message interface{}) {
log.Printf("DEBUG: Docker event: %s", buffer)
}

_, err := http.Post(arg.EventEndpoint, "application/json; charset=utf-8", buffer)
resp, err := http.Post(arg.EventEndpoint, "application/json; charset=utf-8", buffer)
if err != nil {
log.Printf("ERROR: Event sending failed: %s", err)
return
}
// Drain and close the body so the underlying keep-alive connection is
// reused/released. Without this every POST leaks a connection + file
// descriptor (SendEvent runs on every stats tick), eventually exhausting
// the agent's FD limit ("too many open files") and growing memory until OOM.
io.Copy(ioutil.Discard, resp.Body)
resp.Body.Close()
}

func HealthCheck() {
for {
<-time.After(5 * time.Second)
_, err := http.Get(arg.HealthCheckEndpoint)
resp, err := http.Get(arg.HealthCheckEndpoint)

if err == nil {
io.Copy(ioutil.Discard, resp.Body)
resp.Body.Close()
log.Printf("INFO: Swarmpit OK")
break;
}
Expand Down