Windows color#76
Open
mattn wants to merge 2 commits into
Open
Conversation
mattn
commented
Sep 10, 2016
- replace ssh/terminal#IsTerminal with mattn/go-isatty#IsTerminal
- wrap os.Stdout with go-colorable.
|
Thanks for sharing this @mattn .! Bit-rot has set in; I have an experimental branch https://github.com/clach04/sift/tree/issue_92_windows_color where it merges this change with main, essentially replacing golang.org/x/term with github.com/mattn/go-colorable and github.com/mattn/go-isatty
This is likely not ready for prime time like this (as it changes some libraries) but this looks promising 😄 and if Unix works the same, then this may be worth reviewing further. I would love out of box color working for sift under Windows. The test fix from @mattn works well enough for me to be useful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.