Add optional HTTP Basic Authentication for Subsonic servers - #773
Open
ktims wants to merge 2 commits into
Open
Conversation
dweymouth
reviewed
Nov 29, 2025
| BasePlayer | ||
| PlayFile(url string, metadata mediaprovider.MediaItemMetadata, startTime float64) error | ||
| SetNextFile(url string, metadata mediaprovider.MediaItemMetadata) error | ||
| SetHeaders(headers map[string]string) error |
Collaborator
There was a problem hiding this comment.
You will need to implement this in the DLNA player as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #765 . Adds a selectable option for Subsonic servers to (also) send the username/password in an HTTP Basic Auth header. This is useful when Proxy Authentication is used in front of the Subsonic server.
The implementation adds a new
OnServerAuthChangecallback to theServerManager. The callback is called on server change with a map of headers to be added to HTTP requests (allowing flexibility for potential future use cases, e.g. Oauth2 authentication). Hooks are added toplaybackEngineandAudioCacheto configure their respective HTTP clients appropriately.Note: This depends on the parallel PR to
go-subsonic, andgo.modneeds to be updated to reflect the merge commit over there.