4.8.11 sonar fixes - #518
Open
SaipradeepR wants to merge 17 commits into
Open
Conversation
Sonar Violations fixes
Sonar Violations fixes
* KB-2605:Replaced type declaration in ArrayList HashMap with diamond operator * KB-2606:removed generic exceptions
…ply with a naming convention - 36 (#460) 1. Changed the naming conventions.
… 25 (#462) 1. Field names should comply with a naming convention - 25
…- 36 (#463) 1. Method names should comply with a naming convention - 36
* KB-2605:Replaced type declaration in ArrayList HashMap with diamond operator * KB-2606:removed generic exceptions * KB-2606:Removed unncecessary exception being thrown
* KB-2605:Replaced type declaration in ArrayList HashMap with diamond operator * KB-2606:removed generic exceptions * KB-2606:Removed unncecessary exception being thrown * Reverted code in Base64Util due to compilation
* Logger refactor * Unchanged files * Logger refactor ,smell codes * Smell cases fixed sonar * Sonar cube info issues * Sonar cube Blocker issue * conflict resolved * Sonar cube code smells * Sonar cube : KB-2615 Unnecessary imports and KB-2616 Unused assignments * KB-2615 :(Java) Unnecessary imports should be removed * Restored constant * (Java) Unused local variables should be removed, (Java) String literals should not be duplicated
* KB-2605:Replaced type declaration in ArrayList HashMap with diamond operator * KB-2606:removed generic exceptions * KB-2606:Removed unncecessary exception being thrown * Reverted code in Base64Util due to compilation * KB2606: Sonar issues resolved for exception * refactored getter in secretkeyspec class
* KB-2605:Replaced type declaration in ArrayList HashMap with diamond operator * KB-2606:removed generic exceptions * KB-2606:Removed unncecessary exception being thrown * Reverted code in Base64Util due to compilation * KB2606: Sonar issues resolved for exception * refactored getter in secretkeyspec class * removed unnecessary typecasting * Fixed Sonar Bugs
* Logger refactor * Unchanged files * Logger refactor ,smell codes * Smell cases fixed sonar * Sonar cube info issues * Sonar cube Blocker issue * conflict resolved * Sonar cube code smells * Sonar cube : KB-2615 Unnecessary imports and KB-2616 Unused assignments * KB-2615 :(Java) Unnecessary imports should be removed * Restored constant * (Java) Unused local variables should be removed, (Java) String literals should not be duplicated * Sonar code smells:Double Brace Initialization,constant,private fields,public accessibility * Reverted sunbirdApiUserCourse unused properties
* KB-2605:Replaced type declaration in ArrayList HashMap with diamond operator * KB-2606:removed generic exceptions * KB-2606:Removed unncecessary exception being thrown * Reverted code in Base64Util due to compilation * KB2606: Sonar issues resolved for exception * refactored getter in secretkeyspec class * removed unnecessary typecasting * Fixed Sonar Bugs * sonar fixes for KB-2610 (#473) * Sonar issue fix for bug --------- Co-authored-by: shankaragoudab <[email protected]>
* logger change * Logger refactor * Unchanged files * Logger refactor ,smell codes * Smell cases fixed sonar * Sonar cube info issues * Sonar cube Blocker issue * conflict resolved * Sonar cube code smells * Sonar cube : KB-2615 Unnecessary imports and KB-2616 Unused assignments * KB-2615 :(Java) Unnecessary imports should be removed * Restored constant * (Java) Unused local variables should be removed, (Java) String literals should not be duplicated * Sonar code smells:Double Brace Initialization,constant,private fields,public accessibility * Reverted sunbirdApiUserCourse unused properties * sonar issues on Utility classes,Boolean literals,todo tags * Sonar issues fixed for identical implementations,StandardCharsets,depreceted code * sonar issues on Empty arrays,multiple variables,Array designators,Math operands,Collection.isEmpty(),Collections.EMPTY_LIST * Sonar multiple issues fixed * change of boolean from true to false * Sonar issues fixed --------- Co-authored-by: SaipradeepR <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.