4.0.1 redis fix - #166
Open
karthik-tarento wants to merge 21 commits into
Open
Conversation
karthik-tarento
commented
Jan 11, 2023
karthik-tarento
left a comment
karthik-tarento
left a comment
Contributor
Author
There was a problem hiding this comment.
@juhiagl8 -- refer the comments
| public SBApiResponse deleteCache() throws Exception { | ||
| SBApiResponse response = new SBApiResponse(Constants.API_REDIS_DELETE); | ||
| boolean res = redisCache.deleteAllCBExtKey(); | ||
| boolean res = redisCache.deleteAllKey(); |
Contributor
Author
There was a problem hiding this comment.
Just keep the old name - do not create confusion -- deleteAllKey sounds dangerous.
Comment on lines
+174
to
+183
| <dependency> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-data-redis</artifactId> | ||
| <exclusions> | ||
| <exclusion> | ||
| <groupId>io.lettuce</groupId> | ||
| <artifactId>lettuce-core</artifactId> | ||
| </exclusion> | ||
| </exclusions> | ||
| </dependency> |
Contributor
Author
There was a problem hiding this comment.
why we need this ?
Comment on lines
+188
to
+192
| <dependency> | ||
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-pool2</artifactId> | ||
| <version>2.11.1</version> | ||
| </dependency> |
Contributor
Author
There was a problem hiding this comment.
This also seems unnecessary.
karthik-tarento
added a commit
that referenced
this pull request
Jan 27, 2023
karthik-tarento
added a commit
that referenced
this pull request
Jan 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.