Align avatar video CLI default quality with API#2
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
standardtoplus.standard,plus, andmaxquality selection unchanged.Context
The public API launch contract now defaults Avatar Video generation to
plus. The currentv0.1.0CLI release source still defaulted omitted--qualityvalues tostandard, which made the install artifact drift from deployed OpenAPI and public docs.Implementation
src/lib/quality.ts: updates the single sharedDEFAULT_AVATAR_VIDEO_QUALITYconstant toplus.test/cli.test.ts: updates direct CLI request-body expectations for commands that omit quality.test/mcp.test.ts: updates tool execution expectations for omitted quality. Explicit payloads that passquality: "standard"remain covered and unchanged.Verification
pnpm install --frozen-lockfilepnpm test -- cli.test.tspassed: 8 files / 119 testspnpm test -- mcp.test.tspassed: 8 files / 119 testspnpm run typecheckpassedpnpm run build:binarypassedpnpm run secrets:checkpassedpnpm run testpassed: 8 files / 119 testspnpm run buildpassedgit diff --checkpassedManual smoke from the built binary:
./dist/sume --helpkeeps MCP/setup out of launched top-level help../dist/sume avatar-videos create --helpshows--qualitydefaultplus../dist/sume --json tools schema avatar-videos.createdescribes quality asstandard|plus|maxand defaults toplus../dist/sume mcp --json,mcp doctor --json,mcp install --agent codex --json, andsetup agent --agent codex --jsonreport MCP/agent setup as coming soon without writing config.Risk / Rollback
Low risk: this changes only the client-side omitted-quality default. Users can still request
standard,plus, ormaxexplicitly. Rollback is the one-line constant change if the API default changes again.Secrets
No secrets or env files are included.