♿️(frontend) restore presenter focus trapping after share links

[Ovgodd]

Purpose

Fix accessibility regressions in presenter mode introduced with share links: focus escaping to the background document, focus loss on first/last slides, missing keyboard focus on "Copy link to slide", and Escape closing the presenter while the share dropdown is open.

fixfocusresenter.mp4

Proposal

• Restore contain on the presenter FocusScope
• Replace native disabled with aria-disabled on Prev/Next toolbar buttons
• Add a visible :focus-visible indicator on the "Copy link to slide" menu item
• Ignore Escape in presenter shortcuts while the share dropdown popover is open

[github-actions]

Size Change: 0 B

Total Size: 4.36 MB

📦 View Changed

Filename	Size	Change
apps/impress/out/_next/static/673d96b3/_buildManifest.js	0 B	-677 B (removed)	🏆
apps/impress/out/_next/static/41629446/_buildManifest.js	677 B	+677 B (new file)	🆕

_{compressed-size-action}

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Walkthrough

Presenter mode now contains focus within the overlay and preserves open popovers during Escape handling. Floating-bar navigation uses aria-disabled semantics, excludes unavailable controls from initial focus selection, prevents clicks on unavailable controls, and adds visible focus styling. The changelog records the focus-trapping restoration.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: antolc

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main accessibility fix in presenter mode after share links.
Description check	✅ Passed	The description matches the changeset and accurately lists the presenter accessibility fixes implemented.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/presenter-mode-focus-trapping

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@src/frontend/apps/impress/src/features/docs/doc-presenter/hooks/usePresenterShortcuts.ts`:
- Around line 74-83: Update the Escape handling in usePresenterShortcuts so
presenter closure is blocked only when the presenter’s own actions popover is
open. Replace the document-wide .react-aria-Popover query with the floating
bar’s isActionsOpen state or an equivalent presenter-owned ref/marker, while
preserving fullscreen behavior and closing when no presenter popover is active.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: cc09653b-fde9-49f3-9fb4-8e1d309fbcfc

📥 Commits

Reviewing files that changed from the base of the PR and between 9c3bc8a and 24256bb.

📒 Files selected for processing (4)

• CHANGELOG.md
• src/frontend/apps/impress/src/features/docs/doc-presenter/components/PresenterFloatingBar.tsx
• src/frontend/apps/impress/src/features/docs/doc-presenter/components/PresenterOverlay.tsx
• src/frontend/apps/impress/src/features/docs/doc-presenter/hooks/usePresenterShortcuts.ts