Skip to content

🔧(compose) use 1000 as gid for all platforms for frontend-dev service#69

Merged
jbpenrath merged 1 commit into
mainfrom
fix/build-issue
Jun 24, 2026
Merged

🔧(compose) use 1000 as gid for all platforms for frontend-dev service#69
jbpenrath merged 1 commit into
mainfrom
fix/build-issue

Conversation

@jbpenrath

@jbpenrath jbpenrath commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Purpose

On Mac OS gid is 20 and on linux it is 1000. The frontend Dockerfile set node user and group as owner of project resources. But the frontend-dev service use the local user when the service is running. This scenario prevents vite to write within node_modules folder so the frontend application is broken. In order to make the service platform agnostic, we always use 1000 as gid.

Summary by CodeRabbit

  • Bug Fixes
    • Improved container file permissions for the frontend development environment, helping prevent write issues with generated files and dependencies.
    • Updated the development setup to better handle different host user/group configurations, making local container workflows more reliable.

On Mac OS gid is 20 and on linux it is 1000. The frontend Dockerfile set
node user and group as owner of project resources. But the frontend-dev
service use the local user when the service is running. This scenario
prevents vite to write within node_modules folder so the frontend
application is broken. In order to make the service platform
agnostic, we always use 1000 as gid.
@jbpenrath jbpenrath self-assigned this Jun 24, 2026
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2613f12f-06cb-40b7-bb87-699d0eeb30e6

📥 Commits

Reviewing files that changed from the base of the PR and between 19ac7a4 and b10d15b.

📒 Files selected for processing (2)
  • Makefile
  • compose.yaml

📝 Walkthrough

Walkthrough

DOCKER_UID is added to the COMPOSE variable in Makefile so it is passed as an environment variable to all docker compose invocations. In compose.yaml, the frontend-dev service's user field is changed from a bare UID (${DOCKER_USER:-1000}) to an explicit UID:GID pair (${DOCKER_UID:-1000}:1000), with inline comments explaining the host GID mismatch case.

Changes

Docker UID/GID fix for frontend-dev

Layer / File(s) Summary
Inject and apply DOCKER_UID to frontend-dev
Makefile, compose.yaml
Makefile adds DOCKER_UID=$(DOCKER_UID) to the COMPOSE variable so all compose invocations receive it; compose.yaml changes frontend-dev's user from ${DOCKER_USER:-1000} to ${DOCKER_UID:-1000}:1000 to set both UID and GID explicitly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: setting the frontend-dev service GID to 1000 across platforms.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jbpenrath
jbpenrath merged commit 9bb5200 into main Jun 24, 2026
7 checks passed
@jbpenrath
jbpenrath deleted the fix/build-issue branch June 24, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant