Skip to content

🐛(frontend) fix feedback widget mode#68

Merged
jbpenrath merged 1 commit into
mainfrom
fix/feedback-idle-state
Jun 23, 2026
Merged

🐛(frontend) fix feedback widget mode#68
jbpenrath merged 1 commit into
mainfrom
fix/feedback-idle-state

Conversation

@jbpenrath

@jbpenrath jbpenrath commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Purpose

To display the Messages widget, the feedback button must be in idle mode but currently in this one, the onClick event is a noop.

Summary by CodeRabbit

  • Bug Fixes
    • Improved the interaction between the feedback modal and messages widget by adjusting their display sequence.

@jbpenrath jbpenrath self-assigned this Jun 23, 2026
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@jbpenrath, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 32 minutes and 59 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 26a87f49-1f7c-4552-816e-1de88457b8fc

📥 Commits

Reviewing files that changed from the base of the PR and between a62c042 and 64d5573.

📒 Files selected for processing (1)
  • src/frontend/src/features/feedback/Feedback.tsx
📝 Walkthrough

Walkthrough

In Feedback.tsx, the onClick handler's control flow is reordered: modal.open() is now called before the conditional showWidget() call in the non-idle, messages-widget-enabled branch, reversing the previous behavior where the widget was shown and the function returned before the modal could open.

Changes

Feedback onClick control flow reorder

Layer / File(s) Summary
onClick modal/widget execution order
src/frontend/src/features/feedback/Feedback.tsx
modal.open() is invoked before the showWidget() conditional check, so in the non-idle + widget-enabled case the modal now opens first instead of the widget showing and returning early.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title '🐛(frontend) fix feedback widget mode' directly addresses the main change: fixing feedback widget functionality in the frontend.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/frontend/src/features/feedback/Feedback.tsx`:
- Around line 59-66: The onClick function has a logic flow issue where both the
modal and widget can be triggered on the same click, creating conflicting UI
states. The modal.open() call is not protected from executing when the widget is
enabled because the widget check comes after with a return statement.
Restructure the conditions in onClick to be mutually exclusive by either moving
the widget-enabled check first (so it short-circuits before opening the modal)
or by wrapping the modal.open() call in an else condition that prevents it from
executing when the widget is enabled.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8a7d7275-5cf4-4a48-a37d-a6ad741b29a0

📥 Commits

Reviewing files that changed from the base of the PR and between d60e63c and a62c042.

📒 Files selected for processing (1)
  • src/frontend/src/features/feedback/Feedback.tsx

Comment thread src/frontend/src/features/feedback/Feedback.tsx
To display the Messages widget, the feedback button must be
in idle mode but currently in this one, the onClick event
is a noop.
@jbpenrath
jbpenrath force-pushed the fix/feedback-idle-state branch from a62c042 to 64d5573 Compare June 23, 2026 11:01
@jbpenrath
jbpenrath merged commit 19ac7a4 into main Jun 23, 2026
7 checks passed
@jbpenrath
jbpenrath deleted the fix/feedback-idle-state branch June 23, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant