[pull] main from apache:main#175
Merged
Merged
Conversation
* fix: use utf-8 for local tracking text files * fix: read local tracking graph as utf-8 * test: cover local backend utf-8 reads * test: assert utf-8 on local backend text opens Harden the local-backend UTF-8 regression test so it catches missed call sites independently of the host's default encoding. A round-trip assertion alone passes on a UTF-8 host even if a text open drops encoding="utf-8". Wrap the backend's aiofiles.open and assert every text-mode (non-binary) open is explicitly UTF-8; binary opens (mode "rb") stay exempt. Also exercise non-ASCII (incl. CJK) content through annotations, graph.json and children.jsonl end to end. Signed-off-by: André Ahlert <[email protected]> * fix(ci): run local backend utf-8 test with tracking-server deps The new regression test imports burr.tracking.server.backend, which pulls aiofiles (tracking-server extra). The base test job only installed tracking-client, so the top-level server import broke collection and failed all test (3.9-3.12) jobs. - Make the server backend/schema imports lazy and gate the test with pytest.importorskip("aiofiles"), matching the tracking-server-s3 test idiom, so the module still collects with only tracking-client present. - Add the tracking-server extra to the base test job so aiofiles is available and the regression test actually runs across the matrix instead of being skipped everywhere. Signed-off-by: André Ahlert <[email protected]> --------- Signed-off-by: André Ahlert <[email protected]> Co-authored-by: André Ahlert <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )