Skip to content

Fix incorrect logging of Ca - #13070

Merged
scholzj merged 1 commit into
strimzi:mainfrom
tinaselenge:fix-logging
Aug 18, 2026
Merged

Fix incorrect logging of Ca#13070
scholzj merged 1 commit into
strimzi:mainfrom
tinaselenge:fix-logging

Conversation

@tinaselenge

@tinaselenge tinaselenge commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Type of change

Select the type of your PR and delete the other items

  • Bugfix

Description

Ca is logged incorrectly:

2026-08-18 09:32:40 INFO  KafkaRoller:446 - Reconciliation #124(timer) Kafka(default/my-cluster): Rolling Pod my-cluster-dual-role-0/0 due to [Pod has old io.strimzi.operator.common.ca.InternalCa@55880336 certificate generation, io.strimzi.operator.common.ca.InternalCa@55880336 certificate renewal, Pod has old revision, Kafka broker TLS certificates updated]

Add toString() on Ca to return caRole.caName(), so that when Ca gets logged, we should see "Cluster CA" or "Clients CA" rather than raw object reference.

2026-08-18 10:02:20 INFO  KafkaRoller:446 - Reconciliation #4(timer) Kafka(default/my-cluster): Rolling Pod my-cluster-dual-role-0/0 due to [Pod has old Cluster CA certificate generation, Cluster CA certificate renewal, Pod has old revision, Kafka broker TLS certificates updated]

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Update documentation
  • Update CHANGELOG.md (if present)
  • Reference relevant issue(s) and close them after merging
  • Write tests
  • Make sure all tests pass
  • Try your changes inside a Kubernetes cluster, not just from unit tests
  • AI assistance was used to create this PR (see the Strimzi AI policy)

Signed-off-by: Gantigmaa Selenge <[email protected]>
@snyk-io

snyk-io Bot commented Aug 18, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@katheris katheris left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tinaselenge

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.31%. Comparing base (88e86e0) to head (b44f488).

Files with missing lines Patch % Lines
...rc/main/java/io/strimzi/operator/common/ca/Ca.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13070      +/-   ##
============================================
- Coverage     80.33%   80.31%   -0.02%     
+ Complexity     6522     6521       -1     
============================================
  Files           343      343              
  Lines         22695    22696       +1     
  Branches       3079     3079              
============================================
- Hits          18231    18229       -2     
- Misses         3250     3251       +1     
- Partials       1214     1216       +2     
Files with missing lines Coverage Δ
...rc/main/java/io/strimzi/operator/common/ca/Ca.java 71.77% <0.00%> (-0.59%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scholzj

scholzj commented Aug 18, 2026

Copy link
Copy Markdown
Member

/gha run pipeline=regression

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown

⏳ System test verification started: link

The following 6 job(s) will be executed:

  • regression-brokers-and-security-amd64 (cncf-ubuntu-8-32-x86)
  • regression-operators-amd64 (cncf-ubuntu-8-32-x86)
  • regression-operands-amd64 (cncf-ubuntu-8-32-x86)
  • regression-brokers-and-security-arm64 (cncf-ubuntu-8-32-arm)
  • regression-operators-arm64 (cncf-ubuntu-8-32-arm)
  • regression-operands-arm64 (cncf-ubuntu-8-32-arm)

Tests will start after successful build completion.

@scholzj scholzj added this to the 1.2.0 milestone Aug 18, 2026
@github-actions

Copy link
Copy Markdown

❌ System test verification failed: link

@scholzj
scholzj merged commit 9f823c7 into strimzi:main Aug 18, 2026
28 of 31 checks passed
scholzj pushed a commit that referenced this pull request Aug 18, 2026
@tinaselenge
tinaselenge deleted the fix-logging branch August 18, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants