Fix incorrect logging of Ca - #13070
Merged
Merged
Conversation
Signed-off-by: Gantigmaa Selenge <[email protected]>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
scholzj
approved these changes
Aug 18, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13070 +/- ##
============================================
- Coverage 80.33% 80.31% -0.02%
+ Complexity 6522 6521 -1
============================================
Files 343 343
Lines 22695 22696 +1
Branches 3079 3079
============================================
- Hits 18231 18229 -2
- Misses 3250 3251 +1
- Partials 1214 1216 +2
🚀 New features to boost your workflow:
|
Member
|
/gha run pipeline=regression |
|
⏳ System test verification started: link The following 6 job(s) will be executed:
Tests will start after successful build completion. |
ppatierno
approved these changes
Aug 18, 2026
|
❌ System test verification failed: link |
scholzj
pushed a commit
that referenced
this pull request
Aug 18, 2026
Signed-off-by: Gantigmaa Selenge <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Select the type of your PR and delete the other items
Description
Ca is logged incorrectly:
Add
toString()on Ca to return caRole.caName(), so that when Ca gets logged, we should see "Cluster CA" or "Clients CA" rather than raw object reference.Checklist
Please go through this checklist and make sure all applicable tasks have been done