Remove vertx from KafkaAutoRebalanceReconciler - #13064
Open
ShubhamRwt wants to merge 1 commit into
Open
Conversation
Signed-off-by: ShubhamRwt <[email protected]>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13064 +/- ##
============================================
+ Coverage 80.33% 80.34% +0.01%
- Complexity 6522 6529 +7
============================================
Files 343 343
Lines 22695 22703 +8
Branches 3079 3081 +2
============================================
+ Hits 18231 18240 +9
+ Misses 3250 3249 -1
Partials 1214 1214
🚀 New features to boost your workflow:
|
ShubhamRwt
marked this pull request as ready for review
August 18, 2026 05:20
ppatierno
self-requested a review
August 18, 2026 13:34
tinaselenge
reviewed
Aug 18, 2026
| maybeRebalance(scalingNodes) | ||
| .whenComplete((v, error) -> { | ||
| kafkaStatus.setAutoRebalance(kafkaAutoRebalanceStatus); | ||
| if (error != null) { |
Contributor
There was a problem hiding this comment.
This seems to be an additional logic. Doesn't whenComplete already propagates the original result? so if maybeRebalance fails, the returned future fails with the same error and If it succeeds, the returned future succeeds? Do we need to manually check it again?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR remove the use of vertx completely from the KafkaAutoRebalanceReconciler and make use of the of the Java classes(CompletionStage and CompletableFuture).
Checklist
Please go through this checklist and make sure all applicable tasks have been done