fix: adding required permissions to top level and jobs in the workflow#12656
Open
gaganhr94 wants to merge 1 commit intostrimzi:mainfrom
Open
fix: adding required permissions to top level and jobs in the workflow#12656gaganhr94 wants to merge 1 commit intostrimzi:mainfrom
gaganhr94 wants to merge 1 commit intostrimzi:mainfrom
Conversation
Signed-off-by: Gagan H R <[email protected]>
Frawless
reviewed
Apr 22, 2026
| contents: read | ||
| pull-requests: write | ||
| statuses: write | ||
| permissions: {} |
Member
There was a problem hiding this comment.
We use default permissions as
permissions:
contents: read
so maybe we can do the same here and put only pull-requests and statuses to job level
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12656 +/- ##
============================================
- Coverage 75.10% 75.08% -0.03%
+ Complexity 6513 6511 -2
============================================
Files 376 376
Lines 25083 25083
Branches 3271 3271
============================================
- Hits 18839 18833 -6
- Misses 4901 4906 +5
- Partials 1343 1344 +1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Select the type of your PR
Description
Currently the score for the Token Permissions is 9 because the top level permissions and a few job level permissions are missing in the workflows. With this change, the score will improve to 10, since the workflow jobs will run with the minimal permissions. The PR retains conditions like
writeonly at the job level, where it is necessary.Fixes #12655
Checklist
Please go through this checklist and make sure all applicable tasks have been done
Write testsMake sure all tests passUpdate documentationCheck RBAC rights for Kubernetes / OpenShift rolesTry your changes from Pod inside your Kubernetes and OpenShift cluster, not just locallyUpdate CHANGELOG.mdSupply screenshots for visual changes, such as Grafana dashboards