Skip to content

change yaml library to go.yaml.in/yaml/v3#1772

Open
boekkooi-impossiblecloud wants to merge 1 commit into
stretchr:masterfrom
boekkooi-impossiblecloud:yaml-update
Open

change yaml library to go.yaml.in/yaml/v3#1772
boekkooi-impossiblecloud wants to merge 1 commit into
stretchr:masterfrom
boekkooi-impossiblecloud:yaml-update

Conversation

@boekkooi-impossiblecloud

Copy link
Copy Markdown

Summary

The go-yaml project was archived on Apr 1, 2025 and is no longer maintained. Luckily the official YAML organization forked the project and is maintaining it under https://github.com/yaml/go-yaml/tree/v3.

Changes

Replaced all occurrences of gopkg.in/yaml.v3 with go.yaml.in/yaml/v3

Motivation

go-yaml was archived on Apr 1.

Related issues

@dolmen

dolmen commented Aug 1, 2025

Copy link
Copy Markdown
Collaborator

There is work in progress about the license of that project: yaml/go-yaml#6

So we should block until that is stabilized.

@harryzcy

Copy link
Copy Markdown

There is work in progress about the license of that project: yaml/go-yaml#6

So we should block until that is stabilized.

License of go-yaml has changed to Apache now. This PR can move forward

@ccoVeille

Copy link
Copy Markdown
Collaborator

The change are only on main branch for now.

go-yaml has only released -rc for now for the v4.

It might be a bit early

@dolmen dolmen added YAML About YAML and dependency pkg-assert Change related to package testify/assert pkg-require Change related to package testify/require dependencies Pull requests that update a dependency file labels Sep 2, 2025
@mrideout

Copy link
Copy Markdown

I'd like to see this PR merged, with the v3 tag it now has, while the YAML organization works on v4. That move would make it easier to get buy-in for using Testify at organizations that balk at running abandonware. The main branch's README received a July 30 update that makes it clear that v3 will receive security updates.

@fredbi fredbi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change look good to me

@fredbi

fredbi commented Sep 20, 2025

Copy link
Copy Markdown

I think this is good to be merged, so instantly all indirect dependencies to the archive repo would disappear.
Notice that the build tags trick that is used in assert/yaml has no influence on how go.mod propagates dependencies.

fredbi added a commit to fredbi/swag that referenced this pull request Sep 20, 2025
* fixes go-openapi#127

The direct dependencies to this archived repo have been replaced by the active
fork imported from go.yaml.in/yaml/v3.

NOTE: an indirect dependency remains from stretchr/testify.
There is an open PR there to solve this stretchr/testify#1772.
There is not much I can do here to remove this indirect test dependency.

Signed-off-by: Frederic BIDON <[email protected]>
fredbi added a commit to go-openapi/swag that referenced this pull request Sep 20, 2025
* fixes #127

The direct dependencies to this archived repo have been replaced by the active
fork imported from go.yaml.in/yaml/v3.

NOTE: an indirect dependency remains from stretchr/testify.
There is an open PR there to solve this stretchr/testify#1772.
There is not much I can do here to remove this indirect test dependency.

Signed-off-by: Frederic BIDON <[email protected]>
@brackendawson

Copy link
Copy Markdown
Collaborator

The majority of testify users would need to wait until we make a release to benefit from this. Recently we've been on a (very) approximate 6-monthly release cadence, that's not to say we couldn't release earlier than expected to mitigate this and another EOL dependency.

My point is that there isn't a pressing need to rush this. We really do want to merge this, but v4 is in release candidate so I don't think it will be all that long now.

@andig

andig commented Jan 1, 2026

Copy link
Copy Markdown

Happy New Year! Would be nice to see this merged- it's our only remaining dependency on the old library...

oxisto added a commit to confirmate/confirmate that referenced this pull request Feb 7, 2026
This was not completly finished in the last one. It is a problem of testify, but they are working on it (see stretchr/testify#1772).

This hopefully fixes that
oxisto added a commit to confirmate/confirmate that referenced this pull request Feb 8, 2026
This was not completely finished in the last one. It is a problem of
testify, but they are working on it (see
stretchr/testify#1772).
    
This hopefully fixes that

---------

Co-authored-by: Nico Haas <[email protected]>
Comment thread go.sum Outdated
@dolmen

dolmen commented May 6, 2026

Copy link
Copy Markdown
Collaborator

I have now merged #1823 (upgrade objx to v0.5.3).

@boekkooi-impossiblecloud Please rebase.

The [go-yaml](https://github.com/go-yaml/yaml/) project was archived on Apr 1, 2025 and is no longer maintained.
Luckily the official YAML organization forked the project and is maintaining it under https://github.com/yaml/go-yaml/tree/v3.
@boekkooi-impossiblecloud

Copy link
Copy Markdown
Author

@dolmen Thanks you, The PR is rebased. Have a great evening.

@sylr

sylr commented Jul 6, 2026

Copy link
Copy Markdown

Could we merge this ?

@darccio

darccio commented Jul 7, 2026

Copy link
Copy Markdown

In dd-trace-go we got a request to revert the introduction of go.yaml.in/yaml/v3 - which we rejected - and this lead us to investigate what needs to be done to remove gopkg.in/yaml.v3 from our dependency graph.

Our main dependency introducing it is stretchr/testify, and we are glad to see there is an ongoing effort. What needs to be done to get this PR merged? Thanks!

@kgaughan

Copy link
Copy Markdown

@dolmen Are there any further changes blocking this from being merged?

@matmulle

Copy link
Copy Markdown

@dolmen Anything we can help with? I believe changes are now made but the review is still not dismissed.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file pkg-assert Change related to package testify/assert pkg-require Change related to package testify/require YAML About YAML and dependency

Projects

None yet

Development

Successfully merging this pull request may close these issues.