Conversation
|
✅ Linter reported no issues All Python files are correctly formatted with Black. |
|
✅ Linter reported no issues All C/C++ files are correctly formatted with clang-format. |
|
@rykerfish please review and merge. Wait until the last CI ends just in case it fails. |
|
The error comes from find_package(blas) linking against libopenblas instead of the generic symlink called just "libblas.so". When testing I am installing libblas from mkl to test that it is compatible and it fails. |
|
This will probably work, but the resulting package will be compatible only with openblas. The key is in the finc_package(BLAS) and lapack most probably, somehow instructing it to find libblas.so instead of libopenblas.so |
|
Whoops, hadn't seen your original comment before my next commit! I'll do a bit more research to see how we can make it link to something generic instead of openblas specifically |
|
@RaulPPelaez I'm pretty surprised that last one failed. In the logs, I can see it finds the correct library but it still fails. Could this be coming in on the solver-level CMake files? Each one calls |
|
Holly molly, FINALLY. TBH, I cannot explain exactly what the culprit was. Blas has a lot of idiosynchratic behaviors in conda-forge. |
|
Please review again @rykerfish |
rykerfish
left a comment
There was a problem hiding this comment.
Looks good to me! I suspect part of our earlier problem was missing the correct BLAS libraries on the host side but that was hidden under the layer of us linking to the wrong BLAS binary. Nice fix!
Some changes in the conda build infrastructure must have broken the conda build scripts. I noticed some incorrect things here and there that were probably the cause of it.
I also made it so that the conda package is built with a generic blas implementation, instead of relying on MKL. By doing it this way the resulting conda package is compatible with any BLAS, including MKL.