Release/sky 1.4.3#7
Closed
CalistaVerner wants to merge 17 commits into
Closed
Conversation
Move scene-graph names into SkyNodeNames so geometry lookup keys are centralized. Move material and cloud-layer creation into SkyMaterialFactory to separate configuration from control state. Move dome and star-node construction into SkyDomeFactory while preserving runtime node names and public API. Keep README unchanged and validate with :SkyLibrary:compileJava and :SkyLibrary:checkstyleMain.
Point README package instructions and publishing metadata at Take-Some/SkySimulation. Update the GitHub Packages repository URL and SCM metadata after the repository move. Regenerate Gradle publication metadata successfully with :SkyLibrary:generatePomFileForMavenPublication.
Move Yale Bright Star Catalog parsing, entry validation, magnitude filtering, duplicate tracking, and catalog statistics into BrightStarCatalogReader. Leave MakeStarMaps focused on command-line orchestration, map projection, star plotting, and output file generation. Preserve generated asset behavior by validating :SkyAssets:compileJava, :SkyAssets:checkstyleMain, and :SkyAssets:skyTextures.
Move atmospheric parsing and lighting helpers into jme3utilities.sky.atmosphere. Move texture sampling helpers into jme3utilities.sky.material, scene naming helpers into jme3utilities.sky.scene, and updater application helpers into jme3utilities.sky.update. Keep public API classes in jme3utilities.sky and keep SkyMaterialFactory package-private so CloudLayer construction stays encapsulated. Document the source layout in README and validate with :SkyLibrary:compileJava, :SkyLibrary:checkstyleMain, and git diff --check.
Move cube UV and equatorial-to-world coordinate conversion into StarMapProjection. Move pixel-level star drawing and luminosity-to-shape logic into StarMapPlotter. Move dome and cube image generation into StarMapRenderer so MakeStarMaps remains a CLI orchestrator and file writer. Validate with :SkyAssets:compileJava, :SkyAssets:checkstyleMain, :SkyAssets:skyTextures, and git diff --check.
Author
|
1.4.3 Optimisations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.