fix(release): validate release artifacts#40
Conversation
|
Landed as 55a0486. Proof on exact PR head
Caveat: no Eight Sleep credential was available for provider-live API calls. This change only touches release/dependency tooling, so the built release artifact was the applicable live boundary. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b4e26d6153
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| version: latest | ||
| args: release --clean --config /tmp/.goreleaser.yaml | ||
| version: v2.16.0 | ||
| args: release --clean --config /tmp/.goreleaser.yaml --release-notes /tmp/release-notes.md |
There was a problem hiding this comment.
Stop disabling custom release notes
For both tag pushes and manual releases this passes the extracted notes to GoReleaser, but .goreleaser.yaml still has changelog.disable: true; GoReleaser's docs for that setting say it will ignore files passed via --release-notes and render an empty changelog. As a result, the new validation succeeds while the GitHub Release body is empty, so enable the changelog before relying on this flag.
Useful? React with 👍 / 👎.
Summary
eightctl versionoutputUnreleasedgo-toml/v22.4.2 andx/tools0.47.0)Proof
make fmtactionlintshellcheck scripts/release-notesgo test -race ./...make coverage(85.1%)golangci-lint run ./...go vet ./...govulncheck ./...(no vulnerabilities)go mod verify && go mod tidy -diffgoreleaser release --snapshot --clean(6 binaries, 6 archives; packaged version matched metadata; packaged CLI help ran)Provider-live API proof is not applicable to this release-tooling-only change; the built release artifact is the affected runtime boundary.