Skip to content

fix(manage): style Orientations tab rows by using defined CSS module classes (#1687) #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steilerDev merged 1 commit into from
Jun 15, 2026
+363 −27
Merged

fix(manage): style Orientations tab rows by using defined CSS module classes (#1687) #1698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .claude/agent-memory/e2e-test-engineer/MEMORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,15 @@
> Detailed notes live in topic files. This index links to them.
> See: `e2e-pom-patterns.md`, `e2e-parallel-isolation.md`, `story-epic08-e2e.md`, `story-933-dav-vendor-contacts.md`, `milestones-e2e.md`, `story-1248-mass-move.md`, `photo-annotator-e2e.md`

## OrientationsTab E2E coverage (fix #1687, 2026-06-15) — `e2e/tests/orientations.spec.ts`, `e2e/pages/OrientationsPage.ts`

- Comprehensive 8-scenario spec already exists in `e2e/tests/orientations.spec.ts` (NOT under `navigation/`) — covers CRUD, dark mode, sort order, tab navigation, empty state
- CSS fix #1687 changed `styles.listContainer→itemsList` + `styles.listItem→itemRow` in ManagePage.tsx OrientationsTab
- POM `getOrientationRow()` still uses `[class*="itemName"]` — stable anchor regardless of row-level class
- `?tab=orientations` deep-link test added to `settings-manage.spec.ts` URL deep-linking describe block (was the only missing coverage)
- Panel ID: `orientations-panel` (dynamically generated: `${activeTab}-panel`)
- Create form h2: "Create orientation" (NOT "Create New Orientation" — unlike Areas/Trades/HI)

## Paperless correspondent query param name (2026-06-15) — `e2e/tests/invoices/paperless-first-invoice.spec.ts`

- `listPaperlessDocuments()` sends `?correspondent=<id>` (integer, per `paperlessApi.ts` line 27: `params.set('correspondent', ...)`)
Expand Down
Loading
Loading