Add slice_to_unit() C API for single-element slice detection#209
Draft
Copilot wants to merge 5 commits into
Draft
Add slice_to_unit() C API for single-element slice detection#209Copilot wants to merge 5 commits into
slice_to_unit() C API for single-element slice detection#209Copilot wants to merge 5 commits into
Conversation
Copilot
AI
changed the title
[WIP] Implement slice_to_unit() function to determine unit slices
Add Jun 26, 2026
slice_to_unit() C API for single-element slice detection
flexatone
requested changes
Jun 26, 2026
Contributor
|
@copilot instead of returning None for non unit slices, lets return -1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a CPython-exposed utility that collapses unit slices (e.g.,
slice(3, 4),slice(0, 1)) to their integer index and returns-1for all non-unit slices. The goal is to provide a fast, explicit primitive for callers that can substitute scalar indexing when a slice semantically selects exactly one positive-position element.API surface
slice_to_unit()to the extension module method table.arraykit.__init__and added typing in__init__.pyi:def slice_to_unit(__slice: slice, /) -> intCore C implementation
slice_to_unit(PyObject *a)insrc/methods.c(declared insrc/methods.h).sliceobjects (TypeErrorotherwise).stopto be present and integral.start is Noneand treats it as0.step is Noneorstep == 1; any other step returns-1.startonly whenstart >= 0,stop >= 0, andstop - start == 1; otherwise returns-1.Targeted coverage
test/test_util.pyfor:slice(3, 4),slice(0, 1),slice(None, 1)stop, negative startTypeErroron non-slice input)