rename AccountRequestAttachment to IndividualAccountAttachment#65
Open
rafaelcabral-stark wants to merge 1 commit into
Open
rename AccountRequestAttachment to IndividualAccountAttachment#65rafaelcabral-stark wants to merge 1 commit into
rafaelcabral-stark wants to merge 1 commit into
Conversation
rafaelcabral-stark
commented
Jun 11, 2026
rafaelcabral-stark
commented
Contributor
- route changed from /account-request-attachment to /individual-account-attachment
- change IndividualAccountRequest address field from string to object
- add IndividualAccountAttachment delete method
- route changed from /account-request-attachment to /individual-account-attachment - change IndividualAccountRequest address field from string to object - add IndividualAccountAttachment delete method
rafaelcabral-stark
force-pushed
the
fix/individual-account-attachment
branch
from
5a96536 to
6e491bb
Compare
| * | ||
| * Parameters (optional): | ||
| * @param address [string]: Address of the individual. ex: 'R. pamplona, 123' | ||
| * @param address [dictionary object]: Address of the individual. ex: {street: 'R. Pamplona', number: '123', neighborhood: 'Jardim Paulista', city: 'São Paulo', state: 'SP', zipCode: '01405030'} |
Contributor
There was a problem hiding this comment.
não deveria ser uma classe separada?
Contributor
There was a problem hiding this comment.
PHP só nesse caso tá como um objeto direto também
| ]); | ||
| assert(typeof attachments[0].id == 'string'); | ||
| let attachment = await starkinfra.individualAccountAttachment.delete(attachments[0].id); | ||
| assert(typeof attachment.id == 'string'); |
Contributor
There was a problem hiding this comment.
acho que seria bom também validar o status retornado, para ver se está vindo como deleted
Contributor
|
só um detalhe, acho que faltou fazer o merge do bump, pq o changelog esta com a versao 0.18.0, porem outros arquivos ainda estao com 0.17.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.