ci(security): audit only declared runtime deps, not the runner env - #9
Merged
Conversation
The security job ran ``pip-audit --skip-editable``, which audits every package installed in the job's Python — pip, setuptools, wheel, and the rest of the tooling — alongside orca's actual runtime deps. The build then fails on advisories in that tooling: most recently CVE-2026-3219 in ``pip 26.0.1``, which has nothing to do with orca's supply chain. Switch to exporting orca's declared runtime deps via ``poetry export --only main`` and audit that requirements file directly. The audit surface now matches what users actually install when they ``pip install orca-openstackclient``; tooling vulns in the runner can no longer block PRs. ``poetry-plugin-export`` is pinned (``>=1.7``) because it's bundled in poetry < 2.0 but split out in poetry 2.x — the explicit install makes the step work on either side of that boundary.
Vinetos
pushed a commit
to Vinetos/orca-cli
that referenced
this pull request
May 30, 2026
Addresses the remaining high/medium findings from the 2026-04-20 audit: - stackopshq#4 insecure TLS warning + cacert path validation - stackopshq#7 atomic token cache writes - stackopshq#9 publish action pinned to immutable SHA - #13 CI gaps: Poetry cache, poetry build, gitleaks, pip-audit, deploy-docs gated on CI success
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The
securityjob runspip-audit --skip-editableagainst thejob's Python environment. That picks up every package installed in
the runner — pip, setuptools, wheel, and the rest of the tooling —
alongside orca's actual runtime deps. The build then fails on
advisories that have nothing to do with orca's supply chain.
Latest example, blocking #7 and #8 today:
A vuln in
pipitself is a runner-environment problem, not anorca problem. Pinning around it would be a treadmill: every new
pip CVE would block unrelated PRs.
Changes
.github/workflows/ci.yml,securityjob:pip install -e .(no need to install the project — we'renot auditing the resolved env any more).
poetry+poetry-plugin-export>=1.7+pip-audit.The plugin is bundled in poetry < 2.0 but split out in poetry 2.x;
pinning it explicitly keeps the step working on either side.
poetry export --only main --without-hashesto a temp filecontaining only orca's declared runtime deps.
pip-audit --requirement /tmp/runtime-requirements.txt.The audit surface now matches what users actually install when they
pip install orca-openstackclient. Tooling vulns in the runnercan no longer block PRs.
Tests
YAML validated locally; the substantive test is the next CI run on
this PR — if pip-audit no longer fails on CVE-2026-3219 the change
is doing its job.
Risks
build tooling. Acceptable: those tools don't ship with orca, and
the CI runner image is GitHub-managed (vulns there would be
GitHub's responsibility, not ours).
actions/setup-python@v5already caches pip wheels.Recommended merge order
This PR first — it unblocks the security job for both #7 and #8.