fix(security): per-IP rate limiting on login and ingest - #48
Merged
Conversation
Address the pentest finding that authentication and ingestion had no rate limiting (brute-force / credential-stuffing / flood). - A small in-memory sliding-window limiter (no new dependency) caps POSTs per IP: `/api/auth/login` + `/login` at `RATE_LIMIT_LOGIN_PER_MINUTE` (default 10/min) and `/api/ingest` at `RATE_LIMIT_INGEST_PER_MINUTE` (default 600/min). 0 disables. Over-limit returns 429 with `Retry-After`. Argon2's per-attempt cost already slows guessing; this stops the volume. - The limiter is created per app instance and is per-process — documented as needing proxy-level limiting behind a load balancer (multi-instance state is out of scope). Tests: the sliding-window allow/deny logic, and an 11th login in the window → 429. Full suite 230 passed; ruff + mypy(strict) green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pentest remediation — finding #3 (no rate limiting).
/api/auth/ login+/login, default 10/min) and/api/ingest(default 600/min). 0 disables;over-limit → 429 +
Retry-After. Configurable viaRATE_LIMIT_*.Tests: sliding-window logic + 11th login → 429. Full suite 230 passed; ruff +
mypy(strict) green.