chore: release 1.6.0 - #11
Merged
Merged
Conversation
Nothing has shipped since v1.5.0: production still serves that build, so the SEO, privacy, performance and accessibility work merged in #3 and #7-#10 is present on main and absent from ghostbit.dev. Pushes to main only publish the `edge` and `sha-*` image tags. The semver and `latest` tags — which is what a pinned deployment follows — are produced only by a v*.*.* git tag, and the last one predates all of it. Server changes in this release: - meta description, canonical link, /sitemap.xml, noindex on paste pages - star count fetched server-side; no third-party call from the browser and connect-src back to 'self' - landing page 928 KB -> 336 KB, LCP 6.0s -> 3.0s; paste page 515 KB -> 307 KB - form controls labelled, <main> landmark, light-mode contrast fixed - dead static assets removed, including a source map misnamed .sha256 Note the CLI has no changes since v1.5.0, yet this publishes ghostbit-cli 1.6.0 to PyPI with identical code: release.yml reads its version from cli/pyproject.toml, so a server-only release cannot be cut without it. Worth decoupling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexte
Production still serves 1.5.0. Everything merged in #3 and #7–#10 is on
mainand absent fromghostbit.dev:All five Docker builds succeeded after each merge, but a push to
mainonly publishes theedgeandsha-*tags. The semver andlatesttags — what a pinned deployment follows — come only from av*.*.*git tag, and the last one isv1.5.0.Note the version string alone does not prove staleness:
mainwas still1.5.0, so anedgedeployment would report it too. The HTML is what proves it.Changements
Version
1.5.0→1.6.0inpyproject.tomlandcli/pyproject.toml. Minor rather than patch: this carries a new endpoint (/sitemap.xml) and a new setting (GITHUB_REPO). No breaking changes.What merging this triggers
release.yml(push tomaintouchingcli/**) — tests, builds the wheel, creates tagv1.6.0, publishesghostbit-clito PyPI, cuts a GitHub Release.v1.6.0then triggersdocker.yml, publishing the1.6.0,1.6,1andlatestimages.Tests
120 pass,
ruff check/ruff format --checkclean. The CLI wheel was built locally first so the PyPI step cannot fail on a build error:v1.6.0confirmed absent from the remote —release.ymlaborts if the tag already exists.Risques
PyPI publication is irreversible. A version cannot be re-uploaded once published.
And it publishes code that did not change:
git log v1.5.0..HEAD -- cli/is empty.ghostbit-cli 1.6.0will be functionally identical to 1.5.0, released purely becauserelease.ymlreads its version fromcli/pyproject.tomland a server-only release cannot be cut without it. That coupling is worth breaking, as a separate change.