fix(e2e): pin act runner image to a Node 24 digest#399
Merged
Conversation
The harness ran generated workflows on the rolling ghcr.io/catthehacker/ubuntu:act-latest tag, a nondeterministic reference whose Node runtime can change under us. Generated workflows run checkout through act, and the upcoming Node 24 actions need a Node 24 runtime in the job container. Pin the image to a specific digest known to carry Node 24, defined once as actRunnerImage and reused in all three spots (container image, actrc -P mapping, and pre-pull). Add a startup preflight that execs node --version and fails fast with a repin pointer if the major is below 24, so a future image regression is a clear red rather than an obscure action crash. Signed-off-by: Joshua Temple <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the rolling
ghcr.io/catthehacker/ubuntu:act-latestin the e2e harness with a fixed digest (sha256:2f22a801...) that bundles Node 24, and adds a harness preflight that fails loudly if the configured image ever reports Node < 24.Why
The harness runs generated workflows in act, which executes checkout. The upcoming checkout v7 / github-script v9 bumps require Node 24. The rolling tag is nondeterministic and could regress below Node 24 silently. Pinning by digest makes the runtime reproducible; the preflight turns any future drop into a clear repin signal.
Verification
docker run --rm <digest> node --version-> v24.17.0.Note
catthehacker stopped publishing dated tags (newest is pre-Node-24), so a digest is the only deterministic Node-24 reference. An unanchored digest could eventually be GC'd from ghcr; the preflight catches that loudly. A durable follow-up (mirror under stablekernel, or a scheduled digest-refresh) is worth tracking separately.
Prerequisite for the checkout v7 / github-script v9 bumps in the action-pins-manifest goal.